Bump qs from 6.15.0 to 6.15.2#14756
Conversation
npm Package VersionsWarning The following packages have changed files but no version bump:
If these changes affect published code, consider bumping the version. |
rtibblesbot
left a comment
There was a problem hiding this comment.
Dependency Update Review
Package: qs 6.15.0 → 6.15.2
Semver risk: Patch
Dependency type: Production (dependencies in packages/kolibri/package.json)
CI status: All completed checks passing; frontend tests and linting still in progress
Changelog Analysis
Sources consulted:
- PR body (Dependabot-extracted changelog)
- CHANGELOG.md
Breaking changes: None
Security fixes: None
Notable fixes in 6.15.1–6.15.2:
stringify: skip null/undefined entries inarrayFormat: 'comma'+encodeValuesOnlyinstead of crashing in encoderstringify: use configureddelimiteraftercharsetSentinelstringify: applyformatterto encoded key understrictNullHandlingparse: handle nested bracket groupsparse:parameterLimit: InfinitywiththrowOnLimitExceeded: truesilently dropped all parameters
Compatibility Assessment
Kolibri uses qs.stringify in two places:
packages/kolibri/utils/baseClient.js: usesqs.stringify(params, { arrayFormat: 'comma' })— 6.15.2 directly fixes a crash in this exact usage when params contain null/undefined valuespackages/kolibri/client.js: plainqs.stringify(options.data)
No breaking changes. No peer dependency changes. No code migration required. The lockfile also includes minor transitive bumps to caniuse-lite, baseline-browser-mapping, electron-to-chromium, and node-releases — all routine browser-compat-data updates.
Recommendation
APPROVE — patch-only, all fixes, no breaking changes. The 6.15.2 crash fix for arrayFormat: 'comma' directly applies to Kolibri's usage in baseClient.js.
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
Reviewed the pull request diff checking for:
- Correctness: bugs, edge cases, undocumented behavior, resource leaks, hardcoded values
- Design: unnecessary complexity, naming, readability, comment accuracy, redundant state
- Architecture: duplicated concerns, minimal interfaces, composition over inheritance
- Testing: behavior-based assertions, mocks only at hard boundaries, accurate coverage
- Completeness: missing dependencies, unupdated usages, i18n, accessibility, security
- Principles: DRY (same reason to change), SRP, Rule of Three (no premature abstraction)
- Checked CI status and linked issue acceptance criteria
- For UI changes: inspected screenshots for layout, visual completeness, and consistency
Build Artifacts
Smoke test screenshot |
f49b199 to
8652f11
Compare
Bumps [qs](https://github.com/ljharb/qs) from 6.15.0 to 6.15.2. - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.15.0...v6.15.2) --- updated-dependencies: - dependency-name: qs dependency-version: 6.15.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
8652f11 to
7b9fe07
Compare
rtibbles
left a comment
There was a problem hiding this comment.
No concerns from changelog, checks pass.
Bumps qs from 6.15.0 to 6.15.2.
Changelog
Sourced from qs's changelog.
Commits
9aca407v6.15.25e33d33[Dev Deps] update@ljharb/eslint-config21f80b3[Fix]stringify: skip null/undefined entries inarrayFormat: 'comma'+ `e...a0a81ea[Fix]stringify: use configureddelimiteraftercharsetSentinele3062f7[Fix]stringify: applyformatterto encoded key understrictNullHandling0c180a4[Fix]stringify: skip null/undefined filter-array entries instead of crashi...3a8b94a[Tests] add regression tests for keys containing percent-encoded bracket text96755ab[readme] fix grammara419ce5[Fix]parse: handle nested bracket groups and add regression tests3f5e1c5v6.15.1