Drop use of deprecated and soon to be removed ubuntu-20.04 Github Actions runner #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…show as skipped. Separate out EOL Python version tests to run in docker to use ubuntu-latest runner.
rtibbles
changed the title
nucleogenesis
approved these changes
Mar 11, 2025
Member
nucleogenesis
left a comment
nucleogenesis
left a comment
There was a problem hiding this comment.
Checks pass and nothing stuck out to me in the changes so I'll leave merging to your discretion here.
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| - name: Cache pip | ||
| if: ${{ needs.pre_job.outputs.should_skip != 'true' }} |
Member
There was a problem hiding this comment.
Curious where do the needs.pre_job... etc get set? Where are the inputs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
Fix for le-utils part of learningequality/kolibri-ecosystem#41
Reviewer guidance
Do all tests still pass?
Note, this changes the name of some required tests, so it will so some checks as pending when they are really not. When this has been merged, we should update the required checks for this repo.