Skip to content

serialized isolation level decorator for postgres transactions#77

Merged
jamalex merged 4 commits intolearningequality:masterfrom
ralphiee22:serialized_isolation_level
May 28, 2020
Merged

serialized isolation level decorator for postgres transactions#77
jamalex merged 4 commits intolearningequality:masterfrom
ralphiee22:serialized_isolation_level

Conversation

@ralphiee22
Copy link
Copy Markdown
Contributor

@ralphiee22 ralphiee22 commented Feb 17, 2020

Summary

As part of discussions around issues with read concurrency, we are enforcing implementing apps to have a separate db connection of serializable isolation level. This forces the operations to execute serially, as opposed to concurrently.

Issues addressed

Should address data leakage between concurrent transactions.

@ralphiee22 ralphiee22 requested a review from jamalex February 17, 2020 19:30
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 17, 2020

Codecov Report

Merging #77 into master will decrease coverage by 0.09%.
The diff coverage is 72.72%.

@@           Coverage Diff            @@
##           master     #77     +/-   ##
========================================
- Coverage   84.69%   84.6%   -0.1%     
========================================
  Files          30      30             
  Lines        2098    2105      +7     
  Branches      261     262      +1     
========================================
+ Hits         1777    1781      +4     
- Misses        244     246      +2     
- Partials       77      78      +1

@ralphiee22 ralphiee22 force-pushed the serialized_isolation_level branch from 6168588 to ea3497d Compare February 21, 2020 02:27
Copy link
Copy Markdown
Member

@jamalex jamalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@jamalex jamalex merged commit 4a7ab23 into learningequality:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants