Deserialization improvements#84
Merged
bjester merged 6 commits intolearningequality:masterfrom Jun 24, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
- Coverage 83.46% 82.85% -0.62%
==========================================
Files 31 37 +6
Lines 2316 2385 +69
Branches 297 301 +4
==========================================
+ Hits 1933 1976 +43
- Misses 286 309 +23
- Partials 97 100 +3 |
bjester
approved these changes
Jun 11, 2020
Member
bjester
left a comment
There was a problem hiding this comment.
The only thing that confused me initially was that _deserialize_store_model catches and re-raises the error.
Member
Author
Yeah, not immediately obvious from looking at the code what's going on there. I'll add a couple more comments to that section. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some records at times fail to deserialize on KDP (due to missing data, specifically foreign key referents). Added some tests that uncovered a potential cause, and fixed that, and then also added a column called
deserialization_erroron theStoremodel to track issues with deserialization, to support debugging and to be able to skip them for a "lighter weight" deserialization as desired.TODO
Issues addressed
Addresses issues with bulk deserialization seen on KDP.