Skip to content

Conversation

@GarvitSinghal47
Copy link
Contributor

Summary

References

Reviewer guidance

@MisRob MisRob requested review from MisRob and rtibbles November 20, 2024 06:51
@MisRob MisRob self-assigned this Nov 20, 2024
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me here! Thank you @GarvitSinghal47. I will let @rtibbles to make final confirmation before I merge.

Also @rtibbles in this repo, would you please enable GH_UPLOADER_GCP_SA_CREDENTIALS as well? All other sheet secrets are already here. Thank you.

@MisRob MisRob merged commit 8ebf863 into learningequality:develop Dec 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants