Repetitive loadconstants

[ivanistheone]

Summary

If we cd to contentcuration and run pytest -s (to show stdout) we see hundreds of

***** Loading Constants *****
Site: 3 constants saved (2 new)
License: 9 constants saved (9 new)
ContentKind: 7 constants saved (7 new)
FileFormat: 14 constants saved (14 new)
FormatPreset: 22 constants saved (22 new)
Language: 248 constants saved (248 new)
************ DONE. ************

Category

Select one: TEST PERF

How to reproduce

# yarn run services in one tab
# in another tab
pipenv shell
cd contentcuration
pytest -s

Potential fix

replace https://github.com/learningequality/studio/blob/develop/contentcuration/contentcuration/tests/base.py#L47-L50
and https://github.com/learningequality/studio/blob/develop/contentcuration/contentcuration/tests/base.py#L80-L82 etc

with somethin like setUpModule and tearDownModule:
https://docs.python.org/3/library/unittest.html#setupmodule-and-teardownmodule

Real-life consequences

Tests will run a little faster on devs' machines and in CI.

[kollivier]

@ivanistheone I think to use setUpModule and tearDownModule, we have to convert tests to be a Python module (i.e. it needs __init__.py) and I think we'd have to duplicate those functions in tests/views as it is a different module.

The other thing to be careful about is that these functions will be run before django.test.TestCase init code is run. I'm not sure the database will be setup and ready before that.

[kollivier]

Removing from the current sprint for now, we can revisit later but it's not a blocker for any of the current sprint work.