Adding promise polyfill#274
Merged
rtibbles merged 1 commit intolearningequality:developfrom May 10, 2017
Merged
Conversation
DXCanas
commented
May 9, 2017
Member
Author
DXCanas
left a comment
DXCanas
left a comment
There was a problem hiding this comment.
My ESLint atom package came in to clean up a little bit when I saved. Figured it wouldn't do any harm.
| var get_cookie = require("utils/get_cookie"); | ||
| var $ = require('jquery'); | ||
| var get_cookie = require('utils/get_cookie'); | ||
| global.$ = $; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
rtibbles
approved these changes
May 10, 2017
Member
rtibbles
left a comment
rtibbles
left a comment
There was a problem hiding this comment.
This is fine as is - I don't think the performance implications are significantly problematic that we need to async the polyfill.
| var get_cookie = require("utils/get_cookie"); | ||
| var $ = require('jquery'); | ||
| var get_cookie = require('utils/get_cookie'); | ||
| global.$ = $; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using this package, promise support goes back to IE8.
Was going to try and employ this technique so that we wouldn't even load the code, but it seemed like it might be a little messy to write a script outside of
base.js(already dedicated to preparing the environment). @rtibbles thoughts? and if I do employ the implementation he suggests, where should I put that code? inside a<script>tag inbase.html?