Initial websockets integration#3433
Merged
bjester merged 13 commits intolearningequality:websocketsfrom Jul 20, 2022
Merged
Conversation
bjester
reviewed
Jun 29, 2022
bjester
reviewed
Jun 29, 2022
contentcuration/contentcuration/frontend/shared/data/serverSync.js
Outdated
Show resolved
Hide resolved
bjester
requested changes
Jul 14, 2022
Member
bjester
left a comment
bjester
left a comment
There was a problem hiding this comment.
The only blocker is to take another look at the websocket protocol. I added some other thoughts too
contentcuration/contentcuration/frontend/shared/data/serverSync.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/viewsets/websockets/consumers.py
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/viewsets/websockets/consumers.py
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/data/serverSync.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/tests/test_websocket_consumer.py
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/viewsets/websockets/consumers.py
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/viewsets/websockets/consumers.py
Outdated
Show resolved
Hide resolved
bjester
reviewed
Jul 19, 2022
contentcuration/contentcuration/frontend/shared/data/serverSync.js
Outdated
Show resolved
Hide resolved
bjester
reviewed
Jul 19, 2022
contentcuration/contentcuration/frontend/shared/data/serverSync.js
Outdated
Show resolved
Hide resolved
bjester
reviewed
Jul 19, 2022
contentcuration/contentcuration/viewsets/websockets/consumers.py
Outdated
Show resolved
Hide resolved
bjester
reviewed
Jul 19, 2022
Member
bjester
left a comment
bjester
left a comment
There was a problem hiding this comment.
Some more comments regarding things I didn't see in my first pass, and some of your updates. Looking good!
contentcuration/contentcuration/viewsets/websockets/consumers.py
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/viewsets/websockets/consumers.py
Outdated
Show resolved
Hide resolved
bjester
added
TAG: new feature
TAG: dependencies
TODO: needs review
python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Pr integrates Django channels with the project and updates the frontend to open a websocket request when we open a channel. It also implements initial functions in consumers for backend handling of WebSockets and their tests.
Description of the change(s) you made
This PR does implement the following features:
Manual verification steps performed
Ran all tests
Comments
Work is still in progress.