Add optional use_staging_tree parameter to publish_channel function#4980
Merged
rtibbles merged 3 commits intolearningequality:unstablefrom Apr 3, 2025
Merged
Add optional use_staging_tree parameter to publish_channel function#4980rtibbles merged 3 commits intolearningequality:unstablefrom
rtibbles merged 3 commits intolearningequality:unstablefrom
Conversation
rtibbles
reviewed
Apr 2, 2025
Member
rtibbles
left a comment
rtibbles
left a comment
There was a problem hiding this comment.
A couple of very minor comments, nothing blocking. This is excellent, and the tests give a lot of confidence here too.
Member
|
Thanks @taoerman, great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modify publish_channel function to take an optional use_staging_tree parameter as input. If set to true, the function will use staging tree as the base for publishing, and export a -next.sqlite3 database without overwriting or updating existing published database.
Tested locally that a -next.sqlite3 is created by running tests without mocking the storage.
Tested current publishing is not impacted by this change.
References
Issue: #4977
Broader task: #4471
Reviewer guidance
Run unit tests with setUpClass and tearDownClass commented out. The -next.sqlite3 file will be written to minio storage.
Be sure to test the existing publishing behavior is not affected.