Skip to content

Approve unrs-resolver build used by jest#5848

Merged
rtibbles merged 1 commit intolearningequality:unstablefrom
bjester:approve-urns-resolver
Apr 17, 2026
Merged

Approve unrs-resolver build used by jest#5848
rtibbles merged 1 commit intolearningequality:unstablefrom
bjester:approve-urns-resolver

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented Apr 17, 2026

Summary

pnpm was warning about unapproved build, which needs to be approved manually:

 ╭ Warning ─────────────────────────────────────────────────────────────────────╮
 │                                                                              │
 │   Ignored build scripts: unrs-resolver@1.11.1.                               │
 │   Run "pnpm approve-builds" to pick which dependencies should be allowed     │
 │   to run scripts.                                                            │
 │                                                                              │
 ╰──────────────────────────────────────────────────────────────────────────────╯

Looked at why this package is needed:

$ pnpm why unrs-resolver
unrs-resolver@1.11.1
└─┬ jest-resolve@30.3.0
  ├─┬ @jest/core@30.3.0
  │ ├─┬ jest@30.3.0
  │ │ ├─┬ @vue/vue2-jest@29.2.6
  │ │ │ └── studio@0.0.1 (devDependencies)
  │ │ ├─┬ eslint-plugin-jest@28.14.0
  │ │ │ └─┬ kolibri-format@1.0.1
  │ │ │   ├─┬ kolibri-i18n@1.0.0
  │ │ │   │ └── studio@0.0.1 (devDependencies)
  │ │ │   └── studio@0.0.1 (devDependencies)
  │ │ ├─┬ eslint-plugin-jest@29.1.0
  │ │ │ └── studio@0.0.1 (devDependencies)
  │ │ └── studio@0.0.1 (devDependencies)
  │ └─┬ jest-cli@30.3.0
  │   ├── jest@30.3.0 [deduped]
  │   └── studio@0.0.1 (devDependencies)
  ├─┬ jest-config@30.3.0
  │ ├── @jest/core@30.3.0 [deduped]
  │ └── jest-cli@30.3.0 [deduped]
  ├─┬ jest-pnp-resolver@1.2.3
  │ └── jest-resolve@30.3.0 [circular]
  ├─┬ jest-runner@30.3.0
  │ ├── @jest/core@30.3.0 [deduped]
  │ └── jest-config@30.3.0 [deduped]
  └─┬ jest-runtime@30.3.0
    ├── @jest/core@30.3.0 [deduped]
    ├─┬ jest-circus@30.3.0
    │ └── jest-config@30.3.0 [deduped]
    └── jest-runner@30.3.0 [deduped]

References

It's a Rust port of enhanced-resolve 🏁
https://docs.rs/unrs_resolver/latest/unrs_resolver/

Reviewer guidance

  • Tests pass?
  • Does pnpm install complain?

@bjester bjester requested a review from rtibblesbot April 17, 2026 18:23
Copy link
Copy Markdown
Contributor

@rtibblesbot rtibblesbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean maintenance PR. "Build frontend assets" check is still pending, but an onlyBuiltDependencies addition gives no reason to expect it to fail. No UI files changed.

  • praise: PR description includes pnpm why output and a link to the package docs — exactly the right context for a build-script approval, making the risk assessment straightforward.

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

Reviewed the pull request diff checking for:

  • Correctness: bugs, edge cases, undocumented behavior, resource leaks, hardcoded values
  • Design: unnecessary complexity, naming, readability, comment accuracy, redundant state
  • Architecture: duplicated concerns, minimal interfaces, composition over inheritance
  • Testing: behavior-based assertions, mocks only at hard boundaries, accurate coverage
  • Completeness: missing dependencies, unupdated usages, i18n, accessibility, security
  • Principles: DRY (same reason to change), SRP, Rule of Three (no premature abstraction)
  • Checked CI status and linked issue acceptance criteria
  • For UI changes: inspected screenshots for layout, visual completeness, and consistency

Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who am I to argue with my robot friend?

I guess my main surprise is that we've not had to do this on Kolibri yet, because the import-x plugin apparently uses this (according to the readme for this library).

@rtibbles rtibbles merged commit 14f4929 into learningequality:unstable Apr 17, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants