Skip to content

Fix disk space popup in admin users table#5879

Open
LianaHarris360 wants to merge 1 commit intolearningequality:unstablefrom
LianaHarris360:disk-space-popup-fix
Open

Fix disk space popup in admin users table#5879
LianaHarris360 wants to merge 1 commit intolearningequality:unstablefrom
LianaHarris360:disk-space-popup-fix

Conversation

@LianaHarris360
Copy link
Copy Markdown
Member

Summary

Updated the UserStorage unit selector popup, removing DropdownWrapper inside the user table storage popover, while preserving the vertical dropdown positioning with menu-props="{ offsetY: true }"

Manual verification:

  1. Opened the user storage edit popover from the Users table.
  2. Confirmed the unit dropdown is readable and the options are visible without the previous clipped/transparent scrolling behavior.
  3. Confirmed the storage form still saves valid changes and validates invalid input.
  4. Checked the same UserStorage form in the user details modal to confirm the wider selector still fits correctly.

Before:

diskSpacePopupBefore.mov

After:

diskSpacePopupAfter.mov

References

Fixes #5706

Reviewer guidance

Test the disk space editor in both places where UserStorage is used:

  • Users table: click the edit icon in the Disk space column, open the unit dropdown, and verify the options render cleanly over the table.
  • User details modal: open a user profile, use the Disk space form, and verify the layout still looks correct.

The main area to check is dropdown rendering inside the table popover, since that was the broken layout.

AI usage

I used Codex to evaluate the dropdown behavior, reviewed the suggested approach, removed unnecessary shared-component changes, and manually verified the UI behavior.

@LianaHarris360 LianaHarris360 added this to the Studio: Q1 release milestone May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Administration - Users - The disk space popup looks broken

1 participant