Skip to content

Update Assessment Editor layout and card structure #5924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhishek-Punhani wants to merge 2 commits into
base: unstable
Choose a base branch
from
Open

Update Assessment Editor layout and card structure #5924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b4d46e
feat(AssessmentEditor): enhance question card display
Abhishek-Punhani May 19, 2026
95e8a66
update border colors to use CSS variables
Abhishek-Punhani May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 26 additions & 13 deletions ...contentcuration/frontend/channelEdit/components/AssessmentEditor/AssessmentEditor.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ const clickClose = async assessmentItemWrapper => {

const clickEdit = async assessmentItemWrapper => {
await assessmentItemWrapper
.findComponent(`[data-test="toolbarIcon-${AssessmentItemToolbarActions.EDIT_ITEM}"]`)
.findComponent(`[data-test="toolbarMenuItem-${AssessmentItemToolbarActions.EDIT_ITEM}"]`)
.trigger('click');
};

Expand Down Expand Up @@ -210,6 +210,15 @@ describe('AssessmentEditor', () => {
expect(wrapper.findComponent('[data-test="showAnswersCheckbox"]').exists()).toBe(true);
});

it("wraps 'Show answers' checkbox in a page container", () => {
expect(wrapper.find('.show-answers-container').exists()).toBe(true);
});

it('renders question card headers', () => {
expect(wrapper.html()).toContain('Question 1 of 4 — Numeric input');
expect(wrapper.html()).toContain('Question 2 of 4 — Single choice');
});

it("doesn't render answers preview by default", () => {
const items = getItems(wrapper);

Expand All @@ -233,32 +242,36 @@ describe('AssessmentEditor', () => {
it('opens an item on item click', async () => {
const items = getItems(wrapper);
await items.at(1).trigger('click');
const updatedItems = getItems(wrapper);
Copy link
Copy Markdown
Contributor

@rtibblesbot rtibblesbot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Re-querying via getItems(wrapper) after each async trigger('click') is the correct pattern — it ensures assertions run against DOM state after Vue's reactivity cycle has flushed. The previous tests were holding onto stale wrappers.


expect(isItemOpen(items.at(0))).toBe(false);
expect(isItemOpen(items.at(1))).toBe(true);
expect(isItemOpen(items.at(2))).toBe(false);
expect(isItemOpen(items.at(3))).toBe(false);
expect(isItemOpen(updatedItems.at(0))).toBe(false);
expect(isItemOpen(updatedItems.at(1))).toBe(true);
expect(isItemOpen(updatedItems.at(2))).toBe(false);
expect(isItemOpen(updatedItems.at(3))).toBe(false);
});

it('opens an item on toolbar edit icon click', async () => {
it('opens an item on toolbar edit menu click', async () => {
const items = getItems(wrapper);
await clickEdit(items.at(1));
const updatedItems = getItems(wrapper);

expect(isItemOpen(items.at(0))).toBe(false);
expect(isItemOpen(items.at(1))).toBe(true);
expect(isItemOpen(items.at(2))).toBe(false);
expect(isItemOpen(items.at(3))).toBe(false);
expect(isItemOpen(updatedItems.at(0))).toBe(false);
expect(isItemOpen(updatedItems.at(1))).toBe(true);
expect(isItemOpen(updatedItems.at(2))).toBe(false);
expect(isItemOpen(updatedItems.at(3))).toBe(false);
});

it('closes an item on close button click', async () => {
// open an item at first
const items = getItems(wrapper);
await items.at(1).trigger('click');
expect(isItemOpen(items.at(1))).toBe(true);
let updatedItems = getItems(wrapper);
expect(isItemOpen(updatedItems.at(1))).toBe(true);

// now close it
await clickClose(items.at(1));
expect(isItemOpen(items.at(1))).toBe(false);
await clickClose(updatedItems.at(1));
updatedItems = getItems(wrapper);
expect(isItemOpen(updatedItems.at(1))).toBe(false);
});

describe('on "Delete" click', () => {
Expand Down
Loading
Loading