Shortcut displayed on the help page don't work on Mac

[quark67]

In the file en/help.md, we read (for setting a theme):

(<kbd>⌘</kbd>+<kbd>,</kbd> on Mac)

(In the following, I write cmd instead of ⌘ as the later is perhaps not displayed in all operating system; it's the command key)

This don't work on the Safari browser: the shortcut cmd+, is the standard shortcut of a Mac application for its preferences (settings).

If I press cmd+, the window of Safari preferences is opened.

[joulev]

⌘+, is the default keyboard shortcut for Ace editor which LearnLaTeX uses.

I don't have a Mac, but try clicking inside the editor and then ⌘+,, probably it will open the editor settings instead of Safari preferences.

Such shortcut clashes also occur in other browsers too, for example I'm using Firefox and Ctrl+L mean both "go to line" in Ace and "go to URL bar" in Firefox. Which action to be done depends on whether the Ace editor is "active" or not (in other words if I click on the editor then Ctrl+L it will be "go to Ace line", but normally it will "go to URL bar").

[josephwright]

This looks Safari-specific - the override works in Firefox and Chrome

[davidcarlisle]

If there is no keybinding that shows that in Safari I could (I think) add a link in the help page that opens the editor with that panel open. You don't really need it while editing the examples on the site but it is useful to experiment with alternative themes similar to this link on the ACE site that opens the editor with the keybindings list (rather than settings menu) open https://ace.c9.io/demo/keyboard_shortcuts.html

[davidcarlisle]

If you look at the English help you should be able to access the ace settings on that page at least by using the link on the word panel. If that works I may change the wording a bit to make it more obvious and push it across the translated help pages.

[quark67]

Yes, it works by clicking on the word panel, thanks (by the way, on the French translate, the shortcut was mistakenly wrote as ?+ ,, instead ⌘+ ,, this is how I found the bug).

[jejust]

Hi @quark67,
Yes, sorry, my setup is not fully UTF8 compliant yet. Thank you for noticing the mistake!
Feel free to report me other problems in the French version.

[quark67]

@jejust Here's a pull request: #180

[jejust]

Good job!

[davidcarlisle]

This is apparently a Safari-specific issue. In chrome and firefox on the mac the ace shortcut works, but not in Safari.

This isn't really fixable here (we just reference the standard ace keybinding documentation) but we added a direct link to the settings panel in the help page so that safari users can access the panel and experiment with different settings, so closing here.