Skip to content

Amended dockerfile, dockerfile-ci to use nodejs LTS version #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonathanLeeWH merged 1 commit into from
May 26, 2021
Merged

Amended dockerfile, dockerfile-ci to use nodejs LTS version #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
node-version: [12.x]
node-version: [14.x]

steps:
- uses: actions/checkout@v2.3.4
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# With comments to aid in my learning of docker.

# To use official nodejs base docker image.
FROM node:12
FROM node:lts

# The working directory where any subsequent instructions in the Dockerfile will be executed on.
WORKDIR /app
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile-ci
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# With comments to aid in my learning of docker.

# To use official nodejs base docker image.
FROM node:12
FROM node:lts

# The working directory where any subsequent instructions in the Dockerfile will be executed on.
WORKDIR /app
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

[![MIT License](https://img.shields.io/badge/license-MIT-blue)](https://github.com/learnsoftwaredevelopment/SoftwareRepository/blob/master/LICENSE)
![GitHub Node.js CI](https://github.com/learnsoftwaredevelopment/SoftwareRepository/workflows/Node.js%20CI/badge.svg?branch=master)
![App Container CI](https://github.com/learnsoftwaredevelopment/SoftwareRepository/actions/workflows/app-test-container-no-docker-cache.yml/badge.svg?branch=master)]
![App Container CI](https://github.com/learnsoftwaredevelopment/SoftwareRepository/actions/workflows/app-test-container-no-docker-cache.yml/badge.svg?branch=master)

## Introduction

Expand Down Expand Up @@ -169,7 +169,7 @@ A list of the technologies and frameworks used in this project

### Backend Technologies

- Node.js (Node 12)
- Node.js (Node.js LTS)
- MongoDB
- Firebase Authentication

Expand Down