Skip to content

ar71xx: Archer C58/C59/C60 fix qca9886 wireless interface#1198

Closed
heinzek wants to merge 3 commits into
lede-project:masterfrom
heinzek:qca9886
Closed

ar71xx: Archer C58/C59/C60 fix qca9886 wireless interface#1198
heinzek wants to merge 3 commits into
lede-project:masterfrom
heinzek:qca9886

Conversation

@heinzek

@heinzek heinzek commented Jun 29, 2017

Copy link
Copy Markdown
Contributor

This commits fix 5GHz wireless used in Archer C58/C59/C60v1
and set correctly MAC address on this interface.

Second commit fix board.bin file because board-2.bin from official repo has no information
about board used in this "Archers".

@pepe2k pepe2k added the ar71xx label Jun 29, 2017
archer-c59-v1|\
archer-c60-v1)
ath10kcal_extract "art" 20480 12064
ln -sf /lib/firmware/ath10k/pre-cal-pci-0000\:00\:00.0.bin \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing the erroneous line from 6da4f03 ("ath10k-firmware: add qca9888 firmware") ?

 +	$(INSTALL_DATA) \
 +		$(PKG_BUILD_DIR)/QCA9888/hw2.0/board-2.bin \
 +		$(1)/lib/firmware/ath10k/QCA9888/hw2.0/board.bin 

If you do that you could in theory add the following to 11-ath10k-caldata in the switch/case code:

"ath10k/QCA9888/hw2.0/board.bin")
          case $board in
          archer-c59-v1)
                ath10kcal_extract "art" 20480 12064
                ;;
;;

As I said before, I think that the correct way would be make a board-2.bin from the boardData*bin and make a per-device firmware package just like the ipq-wifi from fa03d44 (but for QCA9888). I'm saying this, because Michał Kazior warned me that pushing bad board data can be physically bad for the hardware too.

@heinzek heinzek Jul 3, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it. I sent my boarddata_0.bin from OEM firmware to kvalo and he did not answer.
I create PR on his repo: https://github.com/kvalo/ath10k-firmware/pull/5 it board-2.bin with my boarddata_0.bin.
This board-2.bin work OK wihout any board.bin ( pre_cal_data is still needed)

  +	$(INSTALL_DATA) \
  +		$(PKG_BUILD_DIR)/QCA9888/hw2.0/board-2.bin \
  +		$(1)/lib/firmware/ath10k/QCA9888/hw2.0/board.bin 

i dont know if it is nedded for another board. On QCA9886 is redundant.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried contacting kvalo/QCA via the Mailing-lists: linux-wireless and ath10k-devel?
As I didn't see anything there about the QCA9886 there.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chunkeey, @heinzek, +1 from me for fixing "ath10k-firmware: add qca9888 firmware" and extract board.bin from flash instead of ln hack (even if it actually works). Or, I would wait for fix in upstream (ath10k-firmware).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chunkeey Now i send patch to ath10k-devel http://lists.infradead.org/pipermail/ath10k/2017-July/009930.html
ps. This is my first patch using mail list :)

@pepe2k i try fix @blogic qca9888 commit.
If board-2.bin is not be fixed with boarddata0.bin then better way to use symlink or again download ART from flash?

@kiashan

kiashan commented Jul 5, 2017

Copy link
Copy Markdown

@heinzek
Hi,
If I compile and flash your qca9886 branch on my archer c58, does not boot. But the c58-2 do.
is it normal?!
with the c58-2 brance the 5ghz crash in random mode.
Thanks

heinzek added 3 commits July 5, 2017 21:38
This commit fix 5GHz wireless interface used in Archer C58/C59/C60v1
and set correctly MAC address on this interface.

Signed-off-by: Henryk Heisig <hyniu@o2.pl>
Signed-off-by: Henryk Heisig <hyniu@o2.pl>
Signed-off-by: Henryk Heisig <hyniu@o2.pl>
@jow-

jow- commented Aug 2, 2017

Copy link
Copy Markdown
Member

Pulled into my staging tree: https://git.lede-project.org/94fbbe016c

@JamesT42

Copy link
Copy Markdown

I don't want to nag anybody, but when will this be transfered to the master codebase?

@rotanid

rotanid commented Oct 12, 2017

Copy link
Copy Markdown
Contributor

i feared this will happen, if the PRs are closed before the code is really merged...

@ygoramaral

Copy link
Copy Markdown

I don't want to nag anybody, but when will this be transfered to the master codebase? [2]

@lynxis

lynxis commented Oct 16, 2017

Copy link
Copy Markdown
Member

@ygoramaral usually it takes a couple of days until it reachs the master. It depends on the developer who merged the commit into his own staging tree.

@rotanid

rotanid commented Oct 16, 2017

Copy link
Copy Markdown
Contributor

@lynxis we know, but this has been in a staging tree for 10 weeks now ;-)

@lynxis

lynxis commented Oct 16, 2017

Copy link
Copy Markdown
Member

oh. didn't looked at the timestamp.
ping @jow-

@JamesT42

Copy link
Copy Markdown

@jow- I see you commited something today, maybe you can also commit this today? Thanks.

@jow-

jow- commented Oct 26, 2017

Copy link
Copy Markdown
Member

Sorry for this delay, I messed up my local branches and the commit got lost.

@jow-

jow- commented Oct 26, 2017

Copy link
Copy Markdown
Member

34958c8

@heinzek

heinzek commented Oct 26, 2017

Copy link
Copy Markdown
Contributor Author

@jow- why You merge only one commit?
What with 974e658 and 8d9ca0a

@jow-

jow- commented Oct 27, 2017

Copy link
Copy Markdown
Member

In fact I do, if they're not getting swamped by others :) @heinzek - I picked the other missing commits as well. My apologies for the churn. I promise to handle that better in the future.

@neilmusgrove

Copy link
Copy Markdown

Has anyone got this working? I've updated to a recent snapshot and it now shows the second radio but creating a network from that doesn't work, it never appears to start up.

@JamesT42

JamesT42 commented Nov 12, 2017

Copy link
Copy Markdown

Yes, I just tested 5Ghz Wifi. Make sure you have this installed:
kmod-ath10k
ath10k-firmware-qca9888

@neilmusgrove

Copy link
Copy Markdown

Thanks, I've got it working now. I did have the packages so not sure why it wasn't working before but looks okay now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants