ar71xx: Archer C58/C59/C60 fix qca9886 wireless interface#1198
Conversation
| archer-c59-v1|\ | ||
| archer-c60-v1) | ||
| ath10kcal_extract "art" 20480 12064 | ||
| ln -sf /lib/firmware/ath10k/pre-cal-pci-0000\:00\:00.0.bin \ |
There was a problem hiding this comment.
Would you mind removing the erroneous line from 6da4f03 ("ath10k-firmware: add qca9888 firmware") ?
+ $(INSTALL_DATA) \
+ $(PKG_BUILD_DIR)/QCA9888/hw2.0/board-2.bin \
+ $(1)/lib/firmware/ath10k/QCA9888/hw2.0/board.bin
If you do that you could in theory add the following to 11-ath10k-caldata in the switch/case code:
"ath10k/QCA9888/hw2.0/board.bin")
case $board in
archer-c59-v1)
ath10kcal_extract "art" 20480 12064
;;
;;
As I said before, I think that the correct way would be make a board-2.bin from the boardData*bin and make a per-device firmware package just like the ipq-wifi from fa03d44 (but for QCA9888). I'm saying this, because Michał Kazior warned me that pushing bad board data can be physically bad for the hardware too.
There was a problem hiding this comment.
I thought about it. I sent my boarddata_0.bin from OEM firmware to kvalo and he did not answer.
I create PR on his repo: https://github.com/kvalo/ath10k-firmware/pull/5 it board-2.bin with my boarddata_0.bin.
This board-2.bin work OK wihout any board.bin ( pre_cal_data is still needed)
+ $(INSTALL_DATA) \
+ $(PKG_BUILD_DIR)/QCA9888/hw2.0/board-2.bin \
+ $(1)/lib/firmware/ath10k/QCA9888/hw2.0/board.bin
i dont know if it is nedded for another board. On QCA9886 is redundant.
There was a problem hiding this comment.
Have you tried contacting kvalo/QCA via the Mailing-lists: linux-wireless and ath10k-devel?
As I didn't see anything there about the QCA9886 there.
There was a problem hiding this comment.
@chunkeey Now i send patch to ath10k-devel http://lists.infradead.org/pipermail/ath10k/2017-July/009930.html
ps. This is my first patch using mail list :)
@pepe2k i try fix @blogic qca9888 commit.
If board-2.bin is not be fixed with boarddata0.bin then better way to use symlink or again download ART from flash?
|
@heinzek |
This commit fix 5GHz wireless interface used in Archer C58/C59/C60v1 and set correctly MAC address on this interface. Signed-off-by: Henryk Heisig <hyniu@o2.pl>
Signed-off-by: Henryk Heisig <hyniu@o2.pl>
Signed-off-by: Henryk Heisig <hyniu@o2.pl>
|
Pulled into my staging tree: https://git.lede-project.org/94fbbe016c |
|
I don't want to nag anybody, but when will this be transfered to the master codebase? |
|
i feared this will happen, if the PRs are closed before the code is really merged... |
|
I don't want to nag anybody, but when will this be transfered to the master codebase? [2] |
|
@ygoramaral usually it takes a couple of days until it reachs the master. It depends on the developer who merged the commit into his own staging tree. |
|
@lynxis we know, but this has been in a staging tree for 10 weeks now ;-) |
|
oh. didn't looked at the timestamp. |
|
@jow- I see you commited something today, maybe you can also commit this today? Thanks. |
|
Sorry for this delay, I messed up my local branches and the commit got lost. |
|
In fact I do, if they're not getting swamped by others :) @heinzek - I picked the other missing commits as well. My apologies for the churn. I promise to handle that better in the future. |
|
Has anyone got this working? I've updated to a recent snapshot and it now shows the second radio but creating a network from that doesn't work, it never appears to start up. |
|
Yes, I just tested 5Ghz Wifi. Make sure you have this installed: |
|
Thanks, I've got it working now. I did have the packages so not sure why it wasn't working before but looks okay now. |
This commits fix 5GHz wireless used in Archer C58/C59/C60v1
and set correctly MAC address on this interface.
Second commit fix board.bin file because board-2.bin from official repo has no information
about board used in this "Archers".