Skip to content

ar71xx: Add support to TP-Link EAP120#328

Closed
heinzek wants to merge 1 commit intolede-project:masterfrom
heinzek:master
Closed

ar71xx: Add support to TP-Link EAP120#328
heinzek wants to merge 1 commit intolede-project:masterfrom
heinzek:master

Conversation

@heinzek
Copy link
Copy Markdown
Contributor

@heinzek heinzek commented Sep 20, 2016

Signed-off-by: Henryk Heisig hyniu@o2.pl

/* Configure OBS4 line, for GPIO 4*/
/* ath79_gpio_function_setup(AR934X_GPIO_FUNC_JTAG_DISABLE,
AR934X_GPIO_FUNC_CLK_OBS4_EN);*/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please dont add commented out code

@blogic
Copy link
Copy Markdown
Contributor

blogic commented Sep 26, 2016

target/linux/ar71xx/files/arch/mips/ath79/mach-eap120.c has 3 whitespace errors

:147: trailing whitespace.
#include <linux/platform_data/mdio-gpio.h>
:249: space before tab in indent.
ath79_eth0_pll_data.pll_100 = 0x00000101;
:250: space before tab in indent.
ath79_eth0_pll_data.pll_10 = 0x00001313;

and there is no valid Signed-off-by line

@heinzek heinzek closed this Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants