Change the way SPI and HSSPI modules are compiled#441
Closed
pgid69 wants to merge 1 commit intolede-project:masterfrom
pgid69:brcm63xx-spi-as-module
Closed
Change the way SPI and HSSPI modules are compiled#441pgid69 wants to merge 1 commit intolede-project:masterfrom pgid69:brcm63xx-spi-as-module
pgid69 wants to merge 1 commit intolede-project:masterfrom
pgid69:brcm63xx-spi-as-module
Conversation
…ynamic loadable modules instead of being built into the kernel. Signed-off-by: Gilles Mazoyer <mazoyer.gilles@omega.ovh>
Member
|
NAK. These need to stay built-in, else the kernel won't be able to boot from SPI flash (as required on many devices). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compile them as dynamic loadable modules instead of being built into the kernel.
That's because kernel module https://github.com/pgid69/bcm63xx-phone.git needs full control of the SPI bus so there's must be a way to rmmod bcm63xx-spi without recompiling the kernel.
Signed-off-by: Gilles Mazoyer mazoyer.gilles@omega.ovh