Update to current DATEV format spec #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fields up to format version 700/13
Update StringField and IntegerField output methods to correctly handle nil and empty values according to DATEV CSV format specifications. Changes: - StringField now returns empty string instead of quoted empty string for nil/empty values, ensuring reserved fields are completely empty - IntegerField explicitly returns empty string for nil values - Update tests to verify new nil/empty value handling - Regenerate example CSV files with correct format This resolves validation errors from DATEV Buchungsdatenservice API where reserved fields must be completely empty (no quotes).
Fix CSV field formatting for DATEV API compliance
Owner
|
Since I haven’t worked with the DATEV format for quite some time, I’m not familiar with the current specification. However, since all tests are passing, I’ll go ahead and merge this. Thanks for your contribution! |
Contributor
Author
|
We have used that code in production for a while, so it should be fine. Any plans for a new release? We would like to get rid of our fork. ;) |
Owner
|
Great, just released 0.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Gem output to the current datev spec (adding various fields) and adds additional escapes for header fields (as enforced by the DATEV api)