Closed
Conversation
We know that only the number contain dash, digit, dot and comma, and commodity contain all the others number (but space), hence the regexps. Two different regexp are needed because the commodity can be before or after the amount.
Member
|
Commodities are allowed to contain digits. There are many mutual funds, bond funds etc that have numerals in their names. |
Contributor
Author
|
Mmm, okay. My testing seem to show that in those case, the name is between "" I will add something for those. |
In this case, ledger-split-commodity-string is given the commodity name between " ".
Member
|
Ask John. Maybe that is true I can't remember On Thursday, March 21, 2013, Rémi Vanicat wrote:
Craig, Corona De Tucson, AZ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the bug 922 ledger-split-commodity-string is maybe too complicated, so this version is simpler, using string-match to match regexp on the argument.