Use strdisplaywidth() to calculate foldtext width#84
Merged
alerque merged 1 commit intoledger:masterfrom Oct 8, 2019
Merged
Conversation
Member
|
I'm sorry this has gone un-reviewed. I missed in in the shuffle somewhere. |
Member
|
Scratch that. I had unset all my ledger related options for testing this with the default new users will get. That included |
alerque
approved these changes
Oct 8, 2019
Member
|
Thank you for bot the issue report and the contribution to fix it @lolilolicon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #82, which was filed two weeks ago by myself.
The
s:multibyte_strlencustom function should be removed too, having no more any user.Note I have no experience with vim-script.
My approach here isn't clever, but I hope is rather straightforward.
I have tested with
let g:ledger_fillstring = "xyz", with narrow windows, and with very long amounts.One possible concern might be performance, as the while loops are pretty dumb.