-
Notifications
You must be signed in to change notification settings - Fork 24
dynamic pdo configuration slave #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
ping @leducp i would like your input |
6fd83d6 to
8fa9598
Compare
| if (not entry) | ||
| { | ||
| slave_error("\n update_process_data_output ERROR\n"); | ||
| return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to return a corresponding errno (like ENOENT here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or better: directly the StatusCode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a fan of this method, I want to rework this to avoid having the bit_offset ref being manipulated between function calls (super C like). Need to think a better way to do this, I was thinking of encapsulating the for loop below into this function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it back i cannot really find an alternative. As far as the return code goes. I prefer returning a bool and then configureMapping i can return the appropriate Statuscode for INVALID_INPUT_CONFIGURATION when input mapping is problematic and INVALID_OUTPUT_CONFIGURATION for problems with output mapping
|
|
||
| if (pdo_indices.empty()) | ||
| { | ||
| return StatusCode::INVALID_INPUT_CONFIGURATION; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can authorize an empty mapping no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm not sure if its legal?
| } | ||
| } | ||
|
|
||
| return pdo_indices; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to check if the mapping size if coherent with the user buffers in/out
a5df9a0 to
f60356b
Compare
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 968d0ae |
94d2b1c to
79f03b4
Compare
Closes #226
Slave:
Master