Skip to content

ESI parser compliance - step 1#387

Merged
leducp merged 2 commits into
masterfrom
rework_esi_step_1_multi_devices
May 21, 2026
Merged

ESI parser compliance - step 1#387
leducp merged 2 commits into
masterfrom
rework_esi_step_1_multi_devices

Conversation

@leducp
Copy link
Copy Markdown
Owner

@leducp leducp commented May 7, 2026

This is the first PR of a long run work to reach 100% compatibility with ETG standard

  • Move ESI Parser in a dedicated folder and namespace
  • Handle multiple devices in the same file

Handle multiple devices in the same file
@leducp leducp requested a review from trns1997 May 7, 2026 17:18
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

File Coverage Lines Branches
All files 78% 81% 75%
lib/include/kickcat/Error.h 91% 100% 83%
lib/include/kickcat/SBufQueue.h 80% 98% 63%
lib/master/include/kickcat/SIIParser.h 91% 100% 83%
lib/master/src/Bus.cc 91% 92% 89%
lib/master/src/CoE.cc 61% 71% 51%
lib/master/src/Link.cc 98% 100% 97%
lib/master/src/MailboxSequencer.cc 97% 100% 94%
lib/master/src/MasterOD.cc 99% 99% 100%
lib/master/src/Prints.cc 95% 95% 95%
lib/master/src/Slave.cc 27% 42% 12%
lib/master/src/dc.cc 0% 0% 0%
lib/slave/src/AbstractESC.cc 92% 100% 84%
lib/slave/src/AbstractEmulatedEEPROM.cc 0% 0% 0%
lib/slave/src/ESMStates.cc 96% 98% 94%
lib/slave/src/ESM.cc 95% 100% 90%
lib/slave/src/PDO.cc 92% 97% 88%
lib/slave/src/ESC/EmulatedESC.cc 57% 63% 51%
lib/slave/src/ESC/Lan9252.cc 0% 0% 0%
lib/src/Frame.cc 98% 100% 97%
lib/src/Mailbox.cc 89% 93% 85%
lib/src/SIIParser.cc 40% 50% 30%
lib/src/protocol.cc 94% 92% 96%
lib/src/CoE/OD.cc 98% 98% 98%
lib/src/CoE/protocol.cc 93% 93% 94%
lib/src/CoE/CiA/DS402/StateMachine.cc 93% 94% 92%
lib/src/CoE/mailbox/request.cc 80% 84% 76%
lib/src/CoE/mailbox/response.cc 91% 96% 87%
lib/src/ESI/Parser.cc 86% 90% 82%
lib/src/EoE/protocol.cc 0% 0% 0%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 70609c0

Comment thread lib/src/ESI/Parser.cc Outdated
Comment thread lib/src/ESI/Parser.cc Outdated
Comment thread lib/src/ESI/Parser.cc Outdated
@leducp
Copy link
Copy Markdown
Owner Author

leducp commented May 14, 2026

Agree with the comment: didn't had the time to check if the fields are mandatory or not

@leducp leducp merged commit cb53828 into master May 21, 2026
22 checks passed
leducp added a commit that referenced this pull request May 26, 2026
Parse <Sm>/<Su>/<Fmmu> with full attributes and drive 0x1C00 synthesis from the parsed list.
Move enums and packed register structs into kickcat::SyncManager:: and kickcat::fmmu:: sub-namespaces with throwing fromString.
leducp added a commit that referenced this pull request May 26, 2026
Parse <Sm>/<Su>/<Fmmu> with full attributes and drive 0x1C00 synthesis from the parsed list.
Move enums and packed register structs into kickcat::SyncManager:: and kickcat::fmmu:: sub-namespaces with throwing fromString.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants