240516 김우정 0x02 풀이 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taeyong98
reviewed
May 17, 2024
| int n = scanner.nextInt(); | ||
| scanner.close(); | ||
|
|
||
| StringBuilder output = new StringBuilder(); |
Collaborator
There was a problem hiding this comment.
StringBuilder 라는 객체를 처음 봤는데
이게 append 메소드가 String객체의 += 연산자보다 엄청 빠르다고 하더라고요!
저도 이제 이거로 알고리즘 풀어야 할듯 하네요
Taeyong98
reviewed
May 17, 2024
| StringBuilder line = new StringBuilder(); | ||
|
|
||
| for (int row = 0; row < 2 * n - 1; row++) { | ||
| line.setLength(0); |
Collaborator
There was a problem hiding this comment.
저같은 경우는 for 문이 시작할 때마다 String 객체를 생성 했는데 우정님은 line.setLength(0)을 함으로써 기존 객체를 재사용하는 게 시간적으로 더 효과적이겠네요. 하나 더 배웠습니다. 감사합니다!
Taeyong98
reviewed
May 17, 2024
|
|
||
| return new Pair(max, index+1); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
혹시 클래스를 사용하여 푸신 이유가 따로 있으실까요?
이점이 따로 있다면 알려주시면 감사하겠습니다!
Contributor
Author
There was a problem hiding this comment.
그러게요.. 그냥 아무 생각없이 자연스럽게 함수로 해야겠다는 생각을 했었는데 아마도 배열과 관련된 함수가 최댓값을 찾는 함수, 최솟값을 찾는 함수 등 여러가지가 구현될 수 있으니까 당연하게 다른 기능들과 추가되기 쉽게 당연하게 함수들로 만들어야겠다..라고 생각했던 것 같아요! 지금 문제에서는 다른 분들 코드를 확인했더니 그냥 main에서 하는게 가독성도 좋고 깔끔하겠더라구요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
240516 김우정 0x02 풀이