Skip to content

preventing apps using previous version to crash #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrdezzods merged 2 commits into from
Aug 9, 2017
Merged

preventing apps using previous version to crash #498

mrdezzods merged 2 commits into from
Aug 9, 2017

Conversation

@vhoen
Copy link
Contributor

@vhoen vhoen commented Aug 9, 2017

Prevent this crash :

com.facebook.react.bridge.UnexpectedNativeTypeException: TypeError: expected dynamic type `int64', but had type `null'
        at com.facebook.react.bridge.ReadableNativeMap.getInt(Native Method)

when using one of the latest release.

@arribbar arribbar mentioned this pull request Aug 9, 2017
Open
mrdezzods
mrdezzods requested changes Aug 9, 2017
View reviewed changes
Copy link
Collaborator

@mrdezzods mrdezzods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PropTypes.object is better than any, no?

@vhoen
Copy link
Contributor Author

vhoen commented Aug 9, 2017 •
edited
Loading

Yes, you are right. Even better I used :

PropTypes.oneOfType([
  PropTypes.object,
  PropTypes.number,
])

To support both object and Stylesheet

@mrdezzods mrdezzods merged commit 9d22821 into leecade:master Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrdezzods mrdezzods mrdezzods requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vhoen @mrdezzods