<le-context-menu> component#2
Conversation
|
Visit the preview URL for this PR (updated for commit 562b799): https://le-kit-dev--pr2-feat-le-context-menu-yuk6dkor.web.app (expires Sun, 14 Jun 2026 14:11:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 83b6c4482754ceb1e3e479ff37bafbf0700d64f3 |
| } | ||
|
|
||
| private renderIcon(icon: string) { | ||
| console.log('Rendering icon:', icon); |
| left: 0; | ||
| width: 100vw; | ||
| height: 100vh; | ||
| background: rgba(0, 0, 0, 0.45); |
There was a problem hiding this comment.
is already using --le-popup-backdrop-color with a default value of rgba(0, 0, 0, 0.5).
I think we should use the same value.
Thinking about the multiple properties that we need, like backdrop-filter, maybe it's not a bad idea to have a class like le-backdrop-background
| private startX = 0; | ||
| private startY = 0; | ||
| private isLongPressActive = false; | ||
| private readonly LONG_PRESS_DURATION = 500; // ms |
There was a problem hiding this comment.
We should keep these values in a common place for all long-presses
| * - 'menu-close': closes the menu automatically on scroll | ||
| * - 'fixed-menu': menu scrolls with the page (default) | ||
| */ | ||
| @Prop() pageScrollBehavior: 'blocked' | 'menu-close' | 'fixed-menu' = 'fixed-menu'; |
There was a problem hiding this comment.
Now I think that menu-close will make more sense as a default value
1 participant
A test to generate a component using Google's Antigravity... did not go well, too many fixes and improvements needed after the initial component build