fix(native): test b9016 runtime and expose mainGpu#113
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (29.20%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
- Coverage 77.12% 76.57% -0.55%
==========================================
Files 68 68
Lines 8594 8670 +76
==========================================
+ Hits 6628 6639 +11
- Misses 1966 2031 +65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
b8955tob9016, consuming the publishedllamadart-nativerelease assets.ModelParams.mainGpuand passes it through tollama_model_params.main_gpufor explicit primary GPU selection (Expose main_gpu on ModelParams for explicit Vulkan / CUDA device selection #112).ModelParams.splitModeand passes it through tollama_model_params.split_mode, matching upstream llama.cpp semantics for single-GPU selection viaModelSplitMode.none.GGML_VK_DISABLE_COOPMAT,GGML_VK_DISABLE_COOPMAT2).Validation
dart analyzedart test test/unit/core/models/inference/model_params_test.dartdart test -p vm test/unit/backends/llama_cpp/llama_cpp_service_test.dart./tool/docs/build_site.sh577d10a2b.Issue status
b9016works on RTX 5050 Laptop with CUDA.registeredBackends=[CPU, Vulkan], concrete Vulkan devices, andregistryApisUnavailable=false.GGML_VK_DISABLE_COOPMATplusGGML_VK_DISABLE_COOPMAT2works around them; this workaround is now documented.mainGpuplussplitMode.