fix(android): harden backend selection on Android#96
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
- Coverage 76.90% 76.78% -0.12%
==========================================
Files 67 67
Lines 8368 8394 +26
==========================================
+ Hits 6435 6445 +10
- Misses 1933 1949 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Avoid initializing unsupported Android CPU variant assets when dynamic asset loading bypasses the native score-aware loader. Add regression coverage and startup diagnostics so skipped and selected CPU assets are easier to verify.
Keep Android model loads on CPU when callers leave the backend in auto mode so default configurations avoid unstable Vulkan initialization. Update tests and README notes to match the new Android auto-backend policy.
Document the Android CPU loader hardening and the new CPU-first auto backend policy so the issue 95 follow-up is visible in unreleased notes.
leehack
force-pushed
the
fix/issue-95-android-cpu-score
branch
from
e413ab0 to
8752e02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ggml_backend_scoreduring asset-based backend fallback so unsupported Android CPU variant libraries are skipped before initializationGpuBackend.automodel loads so default configs avoid auto-initializing Vulkan on unstable devices while keeping Vulkan available for explicit opt-inTesting