refactor: move utility functions out of the global namespace #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many utility functions have generic names that may conflict with symbols from other libraries, causing linkage issues. fixes leejet#1011
stduhpf
reviewed
Nov 26, 2025
Contributor
There was a problem hiding this comment.
This is a .h file, not .hpp. There is no such thing as namespaces in C code. Maybe use #ifdef __cplusplus? Or use a prefix instead of a namespace.
Contributor
There was a problem hiding this comment.
Actually the whole file contains c++ stuff like std::strings, nevermind. It should probably be a .hpp instad.
Contributor
Author
There was a problem hiding this comment.
Yeah, that is far from consistent right now. I believe stable-diffusion.h is the only file that's intended to keep compatibility with C.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many utility functions have generic names that may conflict with symbols from other libraries, causing linkage issues.
The 'inline namespace' approach seems ideal for this case, since it's automatically added by any source code that includes
util.h. Moving the whole library to its own namespace would also work, of course.I kept the functions in place to avoid a huge diff, but they should probably be reorganized by visibility.
This is related to #967 , which I suggested for the same reason.
Should fix #1011 .