You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the idea makes sense, but I don’t think this needs a separate Dockerfile.cuda-spark in its current form. From the diff, the Spark variant is still using the same CUDA backend and build flow as the existing CUDA image; the main differences appear to be build parameters:
platform=linux/arm64
CUDA_VERSION=13.0.0
UBUNTU_VERSION=24.04
CMAKE_CUDA_ARCHITECTURES=121
GGML_CUDA_FA_ALL_QUANTS=ON
So this looks more like a CUDA build variant for DGX Spark / GB10 rather than a distinct Dockerfile target that needs to be maintained separately.
I would suggest parameterizing the existing Dockerfile.cuda instead of duplicating most of it into Dockerfile.cuda-spark. For example, Dockerfile.cuda could expose build args such as:
So this looks more like a CUDA build variant for DGX Spark / GB10 rather than a distinct Dockerfile target that needs to be maintained separately.
Oh okay, I can change that.
My initial thought for a dedicated file was that the Spark uses a somewhat unique combination (SM 121 + CUDA 13.0, where other targets use either SM 120 or SM 121 with CUDA 13.1+) but you are probably right, I'll change the PR if that would the repo more nicely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dockerfile.cuda-sparkwith optimized build flags