Force C11/C++17 compile (Fixes GCC 16 build)#1478
Open
cphlipot wants to merge 1 commit intoleejet:masterfrom
Open
Force C11/C++17 compile (Fixes GCC 16 build)#1478cphlipot wants to merge 1 commit intoleejet:masterfrom
cphlipot wants to merge 1 commit intoleejet:masterfrom
Conversation
Currently the project requests the C11 and C++17 feature sets using target_compile_features, however this only gaurentees us a minimum C++ version of C++17, and allows compile to proceed with C++20 (the GCC 16 default) if it is already set. Building Stable-diffusion.cpp with C++20 results in build failures as std::u8string can no longer be assigned to std::string due to C++20 standards changes. Explictly set the required language standard to C++17 in order to ensure we pass/fail the build consistently across compiler toolchains even if compilers by default try to expose a superset of C++17 features. Tested build succeeds on Fedora 44 with GCC 16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the project requests the C11 and C++17 feature sets using
target_compile_features, however this only gaurentees us a minimum
C++ version of C++17, and allows compile to proceed with C++20
(the GCC 16 default) if it is already set.
Building Stable-diffusion.cpp with C++20 results in build failures
as std::u8string can no longer be assigned to std::string due to
C++20 standards changes.
Explictly set the required language standard to C++17 in order to
ensure we pass/fail the build consistently across compiler toolchains
even if compilers by default try to expose a superset of C++17
features.
Tested build now succeeds on Fedora 44 with GCC 16 using the
following commands for vulkan build from build.md:
Closes #1475