Skip to content

ci: add RDNA1 + RDNA2 targets for ROCm 7.13#1511

Merged
leejet merged 1 commit into
leejet:masterfrom
sofiageo:add-gpu-targets
May 18, 2026
Merged

ci: add RDNA1 + RDNA2 targets for ROCm 7.13#1511
leejet merged 1 commit into
leejet:masterfrom
sofiageo:add-gpu-targets

Conversation

@sofiageo
Copy link
Copy Markdown
Contributor

Summary

ROCm 7.13 adds support for RDNA1 and RDNA2 targets. This PR also adds missing gfx1152 Kraken Point target.

Checklist

@leejet
Copy link
Copy Markdown
Owner

leejet commented May 18, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@leejet
Copy link
Copy Markdown
Owner

leejet commented May 18, 2026

It looks like adding these targets has made the CI runtime much longer.

@superm1
Copy link
Copy Markdown
Contributor

superm1 commented May 18, 2026

It looks like adding these targets has made the CI runtime much longer.

Hopefully for the most part they should be cached in ccache though right?

@leejet
Copy link
Copy Markdown
Owner

leejet commented May 18, 2026

ccache can help for repeated builds, but the added GPU targets will still create separate cache entries. So the first CI run, or any run with a cold cache, will still take longer.

@leejet leejet merged commit caa823a into leejet:master May 18, 2026
15 checks passed
@superm1
Copy link
Copy Markdown
Contributor

superm1 commented May 18, 2026

ccache can help for repeated builds, but the added GPU targets will still create separate cache entries. So the first CI run, or any run with a cold cache, will still take longer.

If it turns out to be a problem with CI taking too long overall; I would suggest we can drop the ROCm 7.2.x builds and only fixate on 7.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants