fix: skip permission denied errors in recursive_directory_iterator#1564
Merged
Conversation
Owner
|
Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prevents
sdcpp-webuifrom errorService Unavailablewhen scanning directories with restricted system folders (likelost+found) by addingfs::directory_options::skip_permission_deniedto therecursive_directory_iterator.Additional Information
When
lora_model_dirdefaults to the current working directory (.) and the server is executed from specific directory,fs::recursive_directory_iteratorattempts to scan system folders likelost+found.Since regular users lack read permissions for these directories, the iterator throws a fatal
std::filesystem::filesystem_error(Permission denied), resulting in anEXCEPTION_WHATcrash and partially breaking the web server routing (leading to Service Unavailable errors in the UI).How to reproduce
cd /sd-serveras a non-root userService Unavailablein web (filesystem error: cannot increment recursive directory iterator: Permission deniedcrash upon UI initialization).