Skip to content

fix: correct Gemma3 rope settings and vram limit propagation #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leejet merged 1 commit into from
May 30, 2026
Merged

fix: correct Gemma3 rope settings and vram limit propagation #1583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/conditioner.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2290,6 +2290,11 @@ struct LTXAVEmbedder : public Conditioner {
projector->set_flash_attention_enabled(enabled);
}

void set_max_graph_vram_bytes(size_t max_vram_bytes) override {
llm->set_max_graph_vram_bytes(max_vram_bytes);
projector->set_max_graph_vram_bytes(max_vram_bytes);
}

void set_weight_adapter(const std::shared_ptr<WeightAdapter>& adapter) override {
llm->set_weight_adapter(adapter);
projector->set_weight_adapter(adapter);
Expand Down
8 changes: 4 additions & 4 deletions src/llm.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,8 +879,8 @@ namespace LLM {
input_pos,
nullptr,
head_dim,
GGML_ROPE_TYPE_NORMAL,
0,
GGML_ROPE_TYPE_NEOX,
131072,
rope_theta,
freq_scale,
0.f,
Expand All @@ -892,8 +892,8 @@ namespace LLM {
input_pos,
nullptr,
head_dim,
GGML_ROPE_TYPE_NORMAL,
0,
GGML_ROPE_TYPE_NEOX,
131072,
rope_theta,
freq_scale,
0.f,
Expand Down
Loading