[ISSUE] Series bar chart not shown on version 1.6.32

[vildantursic]

Working version 1.6.31

Non working version 1.6.32

Code snippet from my repo

series: [
    {},
    {
        label: "Alarms",
        stroke: getColorBySeriesIndex(0, "alarms", false),
        fill: getColorBySeriesIndex(0, "alarms", true),
        paths: (uPlot as any).paths.bars({    //// <= PROBABLY THIS PART THAT DOES NOT RENDER BARS (REMOVING IT DOES NOT CHANGE ANYTHING)
            size: [1],
        }),
        points: {
            show: false,
        },
    },
    {
        stroke: getColorBySeriesIndex(0, "alarms", false),
        fill: getColorBySeriesIndex(0, "alarms", true),
        paths: () => null,
        points: {
            show: false,
        },
    },
],

Isolated reproducible code

Work in progress

Since it is minor patch difference I don't think there are changes involved in uPlot.paths.bar() function, I am working on recreating example in JSFiddle but for now this should be sufficient. No errors are shown in console.

[leeoniya]

yeah i dont see a commit that would have affected this. you can try to narrow down the exact breaking commit by changing your package.json dep like this:

"uplot": "leeoniya/uPlot#c198f203a18874702fd45419c78b5f4deee769fb"

that would be a good starting point.

[leeoniya]

@vildantursic ping

[vildantursic]

hey, sorry, was really busy thanx for pinging me 😄 I'll test ASAP to see if I can pinpoint commit where issue started.

[vildantursic]

@leeoniya I found commit that caused it.

Last working commit: 6925ac2cdf8543f6906862feab78a3dc8e05eeaa

Commit that have issue: 9e52bf75effeed4b920a90df4e59ece96e3f2add

I will try (big try 😅) to find potential issue on commit, but can't promise 😄

UPDATE: Definitely can't find exact line 🤣 ... lot of changes on that commit, but if it helps -> reproducing it was same on that commit, I could hover over it and get tooltip in exact shape or rect as it was previously drawn on working version, only fill and stroke are not applied.

[leeoniya]

heh yeah that was a big one. the one you link is a build of this: 6925ac2

if you can make a repro, that would be helpful. i doubt i can think my way through what may have broken :)

[vildantursic]

I'll try to repro it on JSFiddle, can't promise it will be soon, maybe next week.

[vildantursic]

Hey @leeoniya I finally found some time and created repro, and it is super strange 😄 I don't know how it worked before if it is not working now.

https://jsfiddle.net/4ujdnztg/

You have 2 data sets (dataWorking and dataNotWorking) and you'll see difference right away.
Reason for that second array which is now not working is workaround.
If I draw items without points there is not way to click on them (or I didn't found a way to do it), so I kept two arrays, first one for drawing alarm bars and seconds one for drawing points and having data for tooltip and click event so I con't have to dig through initial array.

I hope this helps at least a little. It might very well be issue just on my side because of this particular use case but I wonder how does it work on 1.6.31 and not on 1.6.32.
If it is my issue I would like to hear some suggestions on what would be preferred way to do it to avoid these issues 😄

Thanx

[leeoniya]

@vildantursic thanks for the repro!

so the issue here is that you have a custom data format for the second series, and uPlot's default scale.range function does not know how to extract min and max from this data. you can fix this by implementing your own scales.y.range(). i'm not sure how it ever worked before (it shouldn't have).

in the actual code do you implement your own rendering for the second series that has the custom data format?

    {
       stroke: "#ffff00",
       fill: "#ff0000",
       paths: () => null,
       points: {
         show: false,
       },
     },

is paths: () => null, rendering something in your real code? if not, you can simply omit the second series definition and uPlot will avoid ranging from it. you can also add series.auto: false to have the same effect.