Tweak best practices for LCJS bench #811
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't find instructions on how the benchmark results were measured, so not sure how this would reflect on them. But with
requestAnimationFrameload speed test the loading seems to be ~100 milliseconds faster.We were a bit late on updating our own performance test bench code with the latest best practices, so its understandable that some of this was missed. Would appreciate updating the results but I totally understand if its not done immediately.