Skip to content

✨ Add chain-verifier subagent for parallel review verification#17

Merged
leeovery merged 3 commits intomainfrom
claude/review-agent-opportunities-Ef0Sj
Dec 29, 2025
Merged

✨ Add chain-verifier subagent for parallel review verification#17
leeovery merged 3 commits intomainfrom
claude/review-agent-opportunities-Ef0Sj

Conversation

@leeovery
Copy link
Copy Markdown
Owner

Integrate subagent support into the technical-review phase:

  • Add agents/chain-verifier.md for tracing decisions through artifact chain
  • Update review skill to spawn parallel chain-verifiers for efficiency
  • Update review checklist with parallel verification guidance
  • Document agents in README and CLAUDE.md

Integrate subagent support into the technical-review phase:
- Add agents/chain-verifier.md for tracing decisions through artifact chain
- Update review skill to spawn parallel chain-verifiers for efficiency
- Update review checklist with parallel verification guidance
- Document agents in README and CLAUDE.md
Update chain-verifier and review skill to trace from specification
onwards, not from discussion/research phases:

- Specification is the validated, filtered source of truth
- Earlier phases may contain rejected ideas or rough thoughts
- This avoids false positives from outdated/filtered content
- Aligns with how planning only references specification
Fundamental change to review approach:
- Start from plan (tasks + acceptance criteria), not specification
- Verify ALL tasks, not sampled requirements
- Use spec for context, not as primary source
- Check implementation, tests, AND code quality per task
- Flag both under-testing AND over-testing
- chain-verifier now receives plan task, loads spec context

Code quality review as senior architect:
- Check project-specific skills for conventions
- Apply SOLID, DRY, low complexity principles
- Verify modern language idioms used appropriately
- Check readability, security, performance
@leeovery leeovery merged commit 31846fe into main Dec 29, 2025
@leeovery leeovery deleted the claude/review-agent-opportunities-Ef0Sj branch December 29, 2025 11:06
leeovery added a commit that referenced this pull request Apr 11, 2026
…nals

Flagged during PR #246 convention audit. ~53 skill files use bold
**If ...:** for prelude and STOP-gate-adjacent conditionals where
CLAUDE.md's strict reading would require H4 (#### If). Out of scope
for #246 since it pre-dates the work; logged as idea #17 for a
separate convention sweep or CLAUDE.md clarification.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
leeovery added a commit that referenced this pull request Apr 20, 2026
…nits)

cmdList previously used the project manifest registry when populated,
falling back to a filesystem scan only when the registry was empty.
Work units created before the registry existed are therefore invisible
to 'manifest list' — and to every knowledge-base consumer (bulk index,
status, compact). Real-data test: 9 dirs on disk, 1 registered, only
2 files indexed.

Union both sources so downstream tools see every unit that actually
exists. Deduped via Set. Dot-prefix and malformed-manifest handling
unchanged.

Closes deferred-issues #17.
leeovery added a commit that referenced this pull request Apr 20, 2026
… withdrawn)

The Tick data that motivated deferred-issues #17 (9 dirs on disk, 1 in
registry) was a one-off project-manifest corruption, not a systemic
issue. Migration 031 already populates the registry from the filesystem
on first run, and work units created via 'manifest init' register
atomically. The registry is the authoritative source — a filesystem
scan papering over a corrupted registry masks real problems.

Reverts the cmdList union added in bbe53a4. Test covering the union
case is dropped. deferred-issues.md entry updated to reflect the
misdiagnosis and withdraw the fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants