Conversation
Owner
leeovery
commented
Nov 25, 2025
leeovery
commented
- Replace flat top-level sections with per-question structure
- Each question gets its own section: Context → Options → Journey → Decision
- False paths now documented contextually within each question's journey
- Remove participants field and evolution log
- Simplify to single file per discussion
- Update SKILL.md to reflect per-question approach
- Replace flat top-level sections with per-question structure - Each question gets its own section: Context → Options → Journey → Decision - False paths now documented contextually within each question's journey - Remove participants field and evolution log - Simplify to single file per discussion - Update SKILL.md to reflect per-question approach
- Clarify template is a guide, not a form to fill in - Add optional pros/cons format within Options Considered - Add optional debate structure (positions/resolution) within Journey - Emphasise flexibility - document what naturally emerges
leeovery
deleted the
claude/fix-discussion-template-01CyvJaHFDjQq5QQJ6rUG5wR
branch
leeovery
added a commit
that referenced
this pull request
Feb 4, 2026
Executor SUMMARY: judgment-call flagging is redundant — rule #4 already stops on ambiguity, and cases that slip through do so because the executor doesn't perceive them as ambiguous. Reviewer observable-behavior check: too specific to one example (CLI warnings), not generic enough for all project types. The existing hard rules (stop on ambiguity, stop on spec deviation) already handle what these changes attempted. The real defense against plan gaps is better plans and end-to-end testing — both future work. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
leeovery
added a commit
that referenced
this pull request
Feb 19, 2026
The dependency grapher correctly omits explicit deps for sequential intra-phase tasks, but the integrity reviewer was flagging them as missing. Align criterion #4 with the natural-ordering convention and document the principle in tick format references. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
leeovery
added a commit
that referenced
this pull request
Feb 19, 2026
The dependency grapher correctly omits explicit deps for sequential intra-phase tasks, but the integrity reviewer was flagging them as missing. Align criterion #4 with the natural-ordering convention and document the principle in tick format references. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
leeovery
added a commit
that referenced
this pull request
Mar 28, 2026
…n flow - Mark idea #4 (natural conversation) as done in INDEX.md - README: describe Discussion Map and topic elevation in phase table and key features - CLAUDE.md: update discussion phase description, add Discussion Map status terms Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
leeovery
added a commit
that referenced
this pull request
Apr 20, 2026
…missing path Two related silent-failure modes rolled into one commit: MANIFEST_JS resolution (deferred #5): when neither candidate path existed, the const silently held a non-existent path. First manifest call ENOENT'd inside a silent try/catch and bulk operations returned empty. Now throws at module load with both candidate paths — an installation problem is surfaced immediately, not disguised as 'no artifacts to index'. Error swallowing (deferred #4): discoverArtifacts, getWorkUnitMeta, and the status unindexed-artifact block caught every execFileSync failure identically. 'Work unit not found' is expected (orphans), but corrupt JSON / bad work-unit name / missing manifest file were indistinguishable and silently skipped. Added isManifestKeyNotFound() to recognise expected misses, reportUnexpectedManifestError() to write everything else to stderr with the CLI's own message. Behaviour unchanged for the expected-miss path; real breakage is now visible. Closes deferred-issues #4, #5.
leeovery
added a commit
that referenced
this pull request
Apr 20, 2026
Eliminates the stderr-regex fragility in the knowledge-base helpers that
classify manifest CLI failures. manifest.cjs now uses:
exit 0 — success
exit 1 — real error (corrupt JSON, validation failure, bad args, I/O)
exit 2 — expected miss (work unit not found, path not found, value
not found in list, project manifest not found)
die() takes an optional code (default 1 preserves existing behaviour).
10 'not found' call sites opt in to code 2.
Knowledge helpers (discoverArtifacts, getWorkUnitMeta, cmdStatus
unindexed-artifact block) check err.status === 2 instead of matching
/not found|does not exist/i in stderr. Any future reword of a die()
message no longer risks flipping expected↔unexpected classification.
Test suite: 2 existing assertions updated to expect exit 2 on
not-found paths; new test exercises the 1-vs-2 contract across
missing work unit, missing path, invalid work-type, and corrupt JSON.
Closes deferred-issues #4 (properly this time).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.