Merged
Conversation
Third phase of discussion-plan-implement workflow. Provides: - Strict TDD workflow with hard rules - Phase/task execution guidance - Code quality principles (DRY, SOLID, complexity) - Plan execution with escalation patterns Reference files: - tdd-workflow.md: Red-green-refactor cycle, test derivation - code-quality.md: General quality principles - plan-execution.md: Following plans, phase verification
Update planning skill to work seamlessly with technical-implementation: - Add Phase > Task hierarchy with clear definitions - Require acceptance criteria at phase level - Require micro acceptance (test name) at task level - Size tasks for single TDD cycles (one test, one commit) - Add "How Implementation Uses Plans" section - Streamline template with new task structure - Add edge case mapping table - Remove redundant content, focus on actionable guidance Planning now produces plans that implementation can execute via strict TDD without ambiguity.
Update all test name examples to use Pest format: - Format: it 'describes expected behavior' - Lowercase with spaces, no underscores - Start with "it" Applied across both implementation and planning skills to ensure consistency in the workflow.
Test names should be quoted strings including "it": - Format: "it gets cached value when hit" - Reads as natural sentence - Matches Pest's it() function signature
- Change it() to test() in PHP examples - Remove specific naming convention guidance - Defer to project/framework conventions instead
This reverts commit 34e3e16.
leeovery
deleted the
claude/create-implementation-skill-01PpRCALqvCDttX6Xn5bsRtP
branch
6 tasks
leeovery
added a commit
that referenced
this pull request
Apr 20, 2026
…ack to text Two retrieval-layer fixes: - cmdStatus used to shell out to 'manifest get' per spec topic for the superseded-spec consistency check — N processes for N specs, ~5s on 50-spec repos. Now loads the full manifest tree once via 'manifest list' and resolves topic statuses in memory. Same behaviour, O(1) processes. (deferred #6) - searchHybrid previously returned zero hits when Orama's similarity post-filter masked a query with no strong vector matches, even when BM25 would have found good text matches. Fall back to a fulltext search before returning empty. Search results can only improve. (deferred #15) Closes deferred-issues #6, #15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third phase of discussion-plan-implement workflow. Provides:
Reference files: