Skip to content

Add fix analysis to reviewer and fix_gate_mode#78

Merged
leeovery merged 6 commits intomainfrom
feature/review-fix-analysis
Feb 4, 2026
Merged

Add fix analysis to reviewer and fix_gate_mode#78
leeovery merged 6 commits intomainfrom
feature/review-fix-analysis

Conversation

@leeovery
Copy link
Copy Markdown
Owner

@leeovery leeovery commented Feb 3, 2026

Summary

  • Reviewer now recommends fixes: Each needs-changes issue includes FIX (recommended approach), ALTERNATIVE (optional, when multiple valid approaches exist), and CONFIDENCE (high/medium/low) — giving visibility into the system's fix strategy before the executor re-attempts
  • New fix_gate_mode: Mirrors task_gate_mode (gated/auto) but controls the review-changes gate independently. Users can auto-approve fix analyses while keeping the task approval gate, or vice versa
  • Updated tracking file: fix_gate_mode: gated added to template, reset on session resume, checked during context refresh recovery

Files changed

File Change
agents/implementation-task-reviewer.md New "Fix Recommendations" section + updated output format
skills/technical-implementation/references/steps/invoke-reviewer.md Updated expected result format
skills/technical-implementation/references/steps/task-loop.md Review Changes now checks fix_gate_mode, auto option added
skills/technical-implementation/SKILL.md Tracking file template, context refresh, session reset

Context

When the reviewer returns needs-changes, it currently says what's wrong but not how to fix it. The executor then independently decides the approach with no user visibility. This makes it hard to build confidence toward removing human-in-the-loop gates.

With fix analysis, the user can see the system's reasoning and planned approach before re-execution. Over time, consistently good fix recommendations build the trust needed to enable fix_gate_mode: auto.

Test plan

  • Run implementation with a task that triggers needs-changes — verify reviewer output includes FIX/CONFIDENCE per issue
  • Verify fix analysis is presented in the Review Changes prompt
  • Test a/auto at the fix gate — verify fix_gate_mode updates to auto in tracking file
  • Test session resume resets fix_gate_mode to gated
  • Test fix_gate_mode: auto skips the fix gate and re-invokes executor directly

🤖 Generated with Claude Code

leeovery and others added 6 commits February 3, 2026 22:03
The reviewer now recommends how to fix each issue (FIX, ALTERNATIVE,
CONFIDENCE) rather than only diagnosing what's wrong. This gives the
user visibility into the system's fix strategy before the executor
re-attempts, building confidence toward eventually removing human
gates. A new fix_gate_mode (gated/auto) mirrors task_gate_mode,
allowing users to auto-approve fix analyses independently.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When fix_gate_mode is auto, a counter tracks review-failure cycles
per task. After 3 failed attempts, the loop escalates to the user
regardless of fix_gate_mode. Counter resets on each new task.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Step 0 now checks branch and diff state to auto-detect which
flowchart keys need auditing, reducing unnecessary full audits.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The tripwire counter is now stored in the implementation tracking
file rather than held in memory. Resets to 0 on new task (stage A)
and on session resume. Context refresh recovery checks for mid-loop
state via fix_attempts > 0.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Auto-proceed is the narrow exception (auto + under tripwire
threshold), checked first. All other cases — gated mode or tripwire
triggered — fall through to user presentation. Removes backwards
"see below" reference and "follow gated path above" routing.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace descriptive titles with clear conditional h4 headings that
mirror the structure in section D (Task Gate).

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@leeovery leeovery merged commit 138ac33 into main Feb 4, 2026
@leeovery leeovery deleted the feature/review-fix-analysis branch February 4, 2026 12:20
leeovery added a commit that referenced this pull request Feb 6, 2026
…itions)

V3's integration context created a "convention gravity well" where early
design choices got documented as established patterns and later tasks
faithfully propagated them. V2 without this mechanism won 21/23 tasks.

Removes: integration context file accumulation, plan file access for
executor, expanded exploration instructions, codebase cohesion review
dimension, Convention Consistency quality section.

Keeps: fix recommendations (PR #78), fix_gate_mode (PR #78), full
re-attempt context (PR #77), polish agent (PR #80).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant