Skip to content

Codex/add podcast search and subscription feature#34

Merged
leftouterjoins merged 9 commits intodevelopmentfrom
codex/add-podcast-search-and-subscription-feature
Jun 19, 2025
Merged

Codex/add podcast search and subscription feature#34
leftouterjoins merged 9 commits intodevelopmentfrom
codex/add-podcast-search-and-subscription-feature

Conversation

@leftouterjoins
Copy link
Owner

No description provided.

@leftouterjoins leftouterjoins merged commit 96cd7f4 into development Jun 19, 2025
6 of 7 checks passed
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Function Ignores Parameter, Uses Fixed Categories

The $categories parameter in SponsorBlock::getSegments is immediately overwritten on line 23 with a hardcoded array. This makes the parameter useless, as any custom categories passed by the caller are ignored, and the function will always use the same predefined set of categories.

src/Brickner/Podsumer/SponsorBlock.php#L20-L26

*/
public static function getSegments(string $videoId, array $categories = ['sponsor', 'selfpromo', 'interaction', 'intro', 'outro']): array
{
$categories = ['sponsor', 'selfpromo', 'interaction', 'intro', 'outro'];
if (empty($videoId)) {
return [];
}

Fix in Cursor


BugBot free trial expires on July 22, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant