Skip to content

Merge push-unvkptztolzl Into main#78

Merged
dclong merged 3 commits into
mainfrom
push-unvkptztolzl
Jun 1, 2026
Merged

Merge push-unvkptztolzl Into main#78
dclong merged 3 commits into
mainfrom
push-unvkptztolzl

Conversation

@dclong

@dclong dclong commented May 31, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Gitpod configuration and introduces a new VS Code devcontainer configuration for a Fedora Codespace. The feedback recommends adding the Ruff and Pyright extensions to the devcontainer configuration to align with the repository's development conventions for linting, formatting, and type safety.

Comment thread .devcontainer/devcontainer.json
@dclong dclong force-pushed the push-unvkptztolzl branch 3 times, most recently from d5372b1 to a480834 Compare May 31, 2026 20:57
@dclong

dclong commented May 31, 2026

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new .devcontainer/devcontainer.json configuration file to set up a Fedora-based VS Code development environment, while removing an old Gitpod configuration. A review comment points out that version pinning is not supported in the extensions list of devcontainer.json (specifically for asvetliakov.vscode-neovim@1.18.24) and suggests removing the version suffix to prevent installation failure.

Comment thread .devcontainer/devcontainer.json Outdated
@dclong dclong force-pushed the push-unvkptztolzl branch from a480834 to 8ac9021 Compare May 31, 2026 21:00
@dclong

dclong commented May 31, 2026

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the Gitpod environment configuration with a new VS Code Devcontainer configuration. The reviewer identified two invalid VS Code extension IDs (anthropic.claude-code and astral-sh.ty) that are actually CLI tools and would cause installation errors, offering appropriate suggestions to remove them.

Comment thread .devcontainer/devcontainer.json
Comment thread .devcontainer/devcontainer.json
@dclong dclong merged commit 6f2184e into main Jun 1, 2026
8 checks passed
@dclong dclong deleted the push-unvkptztolzl branch June 2, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant