Updated data-grid to v2.0.13 with new features and fixes#21
Merged
lekoala merged 10 commits intolekoala:masterfrom Aug 20, 2025
Merged
Updated data-grid to v2.0.13 with new features and fixes#21lekoala merged 10 commits intolekoala:masterfrom
lekoala merged 10 commits intolekoala:masterfrom
Conversation
… input-related elements from triggering row expansion, enhancing user interaction.
- Updated `data-grid.js` to clarify multi-select functionality and introduced a `singleSelect` property. - Enhanced `SelectableRows` class in `selectable-rows.js` with new methods for single selection and updated event handling for checkboxes and radio buttons. - Added new CSS variables for selected background color and improved input styles in `_core.scss`.
…ering when browser hard refreshes.
- Updated `urlChanged`, `fixPage`, `configureUi`, `refresh`, and `reload` methods to return `this` for improved method chaining. - Added JSDoc comments to `refresh` and `reload` for better clarity on parameters and return types.
- Updated the `getSelection` method in `DataGrid` and `SelectableRows` classes to accept a variable number of keys, improving data selection flexibility. - Documentation comments were revised to clarify the new functionality, and the internal logic was adjusted to return appropriate data based on the provided keys.
- Updated `BaseElement` to improve dataset normalization by adding conditions to skip certain keys. - Modified `normalizeData` to ensure input is a string before parsing, preventing runtime errors and improving reliability.
Owner
|
looking good as always ;-) |
Contributor
Author
|
Thank you so much Thomas! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Thomas,
I hope you're doing well these days. Another round of changes for your review. We are currently using lots of data-grid for a new build of an application and found the changes would help a lot for our development. Please let me know if the changes are ok.
As always, thank you so much.
Summary of changes:
--selected-bgcolorvariable for selected rows, improved handling of single and multiple selections, and refactoring of methods for better data management.connectedCallbackmethod is now asynchronous for improved initialization, and the#setNoDatamethod manages "no data" messages effectively.package.jsonandpackage-lock.jsonto ensure compatibility with the latest dependencies.