Skip to content

removed iso8601 dependency from the json date feed parser and replace…#401

Closed
bazbrad765 wants to merge 0 commit into
lemon24:masterfrom
bazbrad765:master
Closed

removed iso8601 dependency from the json date feed parser and replace…#401
bazbrad765 wants to merge 0 commit into
lemon24:masterfrom
bazbrad765:master

Conversation

@bazbrad765
Copy link
Copy Markdown
Contributor

removed iso8601 dependency from the json date feed parser and replaced with datetime.fromisoformat(). Also updated 4 asserts within test_cli that was not allowing whitespaces within project folder paths by replacing split() with rsplit(None,1) to split at the last whitespace. Black formatter automatically updated all the quotes to double quotes and i cant quite figure out how to turn that off within my vscode

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 96.73913% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.15%. Comparing base (09f57ea) to head (a1a473a).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/reader/_parser/jsonfeed.py 92.30% 1 Missing and 1 partial ⚠️
tests/test_cli.py 98.48% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
- Coverage   94.34%   91.15%   -3.19%     
==========================================
  Files         107      106       -1     
  Lines       13673    13574      -99     
  Branches     1006     1002       -4     
==========================================
- Hits        12900    12374     -526     
- Misses        692     1147     +455     
+ Partials       81       53      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lemon24 added a commit that referenced this pull request May 14, 2026
so it's picked up by editors etc.

Related to #401.
Comment thread src/reader/_parser/jsonfeed.py Outdated
except ValueError:
return None
assert isinstance(dt, datetime)
if dt.tzinfo is None:
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage fails here, since this is a corner case it should be fine to add # pragma: no cover for this if.

@lemon24
Copy link
Copy Markdown
Owner

lemon24 commented May 14, 2026

Black formatter automatically updated all the quotes to double quotes and i cant quite figure out how to turn that off within my vscode

This is partly my bad, I usually run Black using pre-commit, and the -S flag (skip string normalization) is in .pre-commit-config.yaml (so there's no way for your editor to pick it up).

I moved that config in pyproject.toml in 0694f20, if you apply your changes (except the quote stuff) on top of latest, the quotes should be left alone now.


Added a comment about test coverage, see above.

(The docs failure you can ignore, it'll be fixed in another PR.)

@lemon24
Copy link
Copy Markdown
Owner

lemon24 commented May 15, 2026

I moved that config in pyproject.toml in 0694f20, if you apply your changes (except the quote stuff) on top of latest, the quotes should be left alone now.

You still need to apply only your changes on top of latest master, without the quote changes; the diff should contain only the actual changes (dep removal + test fix); this is both to make it easier to review (in general, not particularly here), and to keep git blame clean (formatting changes with "remove so and so dependency" as commit message is confusing); general guidance.

  1. sync your fork
  2. re-apply desired changes
  3. commit and push (the pull request should update automatically, I think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants