removed iso8601 dependency from the json date feed parser and replace…#401
removed iso8601 dependency from the json date feed parser and replace…#401bazbrad765 wants to merge 0 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #401 +/- ##
==========================================
- Coverage 94.34% 91.15% -3.19%
==========================================
Files 107 106 -1
Lines 13673 13574 -99
Branches 1006 1002 -4
==========================================
- Hits 12900 12374 -526
- Misses 692 1147 +455
+ Partials 81 53 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
so it's picked up by editors etc. Related to #401.
| except ValueError: | ||
| return None | ||
| assert isinstance(dt, datetime) | ||
| if dt.tzinfo is None: |
There was a problem hiding this comment.
Coverage fails here, since this is a corner case it should be fine to add # pragma: no cover for this if.
This is partly my bad, I usually run Black using pre-commit, and the -S flag (skip string normalization) is in .pre-commit-config.yaml (so there's no way for your editor to pick it up). I moved that config in pyproject.toml in 0694f20, if you apply your changes (except the quote stuff) on top of latest, the quotes should be left alone now. Added a comment about test coverage, see above. (The |
You still need to apply only your changes on top of latest master, without the quote changes; the diff should contain only the actual changes (dep removal + test fix); this is both to make it easier to review (in general, not particularly here), and to keep
|
removed iso8601 dependency from the json date feed parser and replaced with datetime.fromisoformat(). Also updated 4 asserts within test_cli that was not allowing whitespaces within project folder paths by replacing split() with rsplit(None,1) to split at the last whitespace. Black formatter automatically updated all the quotes to double quotes and i cant quite figure out how to turn that off within my vscode