ci: validate release build on pull requests#8
Merged
Conversation
Add a pull_request trigger to build.yml so the release build is validated on PRs, mirroring lemonade-sdk/llama.cpp. The pack/upload and release jobs remain gated on schedule/create_release, so nothing is published on a PR run. Scope the trigger to the workflow file itself: the build jobs clone source from upstream (leejet/stable-diffusion.cpp), so only changes to this workflow can affect a PR run's outcome. On PRs, the CUDA matrices build a single representative arch (sm_89) instead of all seven; packaging logic is identical across sm_*, and the full matrix still runs on schedule/dispatch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds pull request validation to the CI workflow so that changes to the release build workflow itself can be compile-tested in PRs without publishing artifacts or creating releases.
Changes:
- Add a
pull_requesttrigger scoped to changes in.github/workflows/build.yml. - Reduce CUDA PR workload by building only a single representative architecture (
sm_89) on PR events while keeping the full matrix for scheduled/manual runs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate the release build on pull requests, mirroring the approach in lemonade-sdk/llama.cpp.
pull_requesttrigger tobuild.yml, scoped viapathsto the workflow file itself. The build jobs clone source from upstream (leejet/stable-diffusion.cpp), so only changes to this workflow can affect a PR run's outcome.releasejobs stay gated onschedule || create_release, so nothing is published on a PR run — only the compile is exercised.sm_89) instead of all seven. Packaging logic is identical acrosssm_*, so one arch is a sufficient sample; the full matrix still runs on schedule/dispatch.Effect on a PR run
sm_89) instead of 14.cmakeinvocation).🤖 Generated with Claude Code