Localstorage: fix missing cast to Path#109
Merged
lemonsaurus merged 1 commit intolemonsaurus:mainfrom Jun 8, 2022
Merged
Conversation
The current code assumed that `path` is already a `pathlib.Path` instance, despite it being a string. This commit fixes that.
|
Faced this issue and Lilian was kind enough to fix it |
lemonsaurus
approved these changes
Jun 8, 2022
Owner
lemonsaurus
left a comment
lemonsaurus
left a comment
There was a problem hiding this comment.
Seems sane and harmless. Let's do it.
|
@lemonsaurus I'm not really familiar with python, I'm assuming I'll have to wait for a release to get the fix? Is there a way I can just use the latest commit with PyPi? |
Contributor
Author
|
@Jamalam360 it should be live on Dockerhub, if you are using a container you should already be good to go. Otherwise, you'll have to check out the repository manually. |
Owner
|
@Jamalam360 Blackbox 2.2.0 contains this change, and is live now on PyPI! |
|
Thank you both! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code assumed that
pathis already apathlib.Pathinstance, despite it being a string. This commit fixes that.