🐛 Fix: Make blackbox exit with code 1 when database backups fail#173
Merged
lemonsaurus merged 2 commits intomainfrom Jul 28, 2025
Merged
🐛 Fix: Make blackbox exit with code 1 when database backups fail#173lemonsaurus merged 2 commits intomainfrom
lemonsaurus merged 2 commits intomainfrom
Conversation
Ensures the CLI returns proper exit code when any database backup fails by setting success = False before continuing to next database.
Add test suite for CLI exit code behavior to validate that database and storage failures properly return False from run(), ensuring exit code 1 is returned to indicate failure. Tests cover: - Successful backups return True - Database failures return False - Storage failures return False - Mixed success/failure scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
success = Falsewhen database backup failsTest Coverage
Impact
This change enables proper monitoring and alerting when database backups fail, which is essential for production environments and automated workflows.
Fixes #156