Skip to content

v0.1.7

Choose a tag to compare

@lengain lengain released this 14 Jun 03:16
· 9 commits to main since this release

v0.1.7 - Concurrency Bug Fixes

Bug Fixes from Code Review

1. parallel_cleanup_projects — rescue on wrong scope (project_writer_patch.rb)

  • The rescue StandardError was attached to the each block, not inside pool.post
  • Thread exceptions were silently swallowed by Concurrent::FixedThreadPool
  • Fix: moved rescue inside the pool.post do...end block

2. parallel_recreate_user_schemes — same structural bug (project_writer_patch.rb)

  • Identical pattern: rescue on each instead of inside pool.post
  • Fix: moved rescue inside the pool.post do...end block

3. integrate_user_targets — thread exception propagation (user_integrator_patch.rb)

  • Thread.new with no error handling; threads.each(&:join) raises on first failure
  • Remaining threads become orphaned, potentially leaving xcodeproj in inconsistent state
  • Fix: added rescue StandardError inside each Thread.new block with warning

4. save_cached_result — inconsistent indentation (analyzer_patch.rb)

  • Data hash construction at wrong indent level suggesting incorrect control flow
  • Fix: aligned to correct indentation inside begin block

Full changelog: commits