Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue DEV-1366 by modifying the passkey challenge cleanup behavior to enable retry attempts after verification failures. Previously, challenge mappings were deleted after both successful and failed verifications, preventing users from retrying with different passkeys.
Changes:
- Modified challenge cleanup logic to only delete mappings on successful verification
- Added debug logging for failed verification attempts to track retry scenarios
src/core/modules/better-auth/core-better-auth-api.middleware.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.