Allow all users to change their own password#164
Merged
Conversation
cloudsftp
force-pushed
the
change-password
branch
from
5746f84 to
0afcf45
Compare
cloudsftp
force-pushed
the
change-password
branch
from
eb59e8e to
8a983d4
Compare
cloudsftp
changed the title
Contributor
Author
|
I manually redid the UI changes from scratch and added translations for the new fields. Now there is a new tab in the settings for all users, that allows to change the password. I am pretty happy with the implementation. |
Member
|
Just wanted to say thank you for your contribution. Sorry I haven't had a chance to review this. |
Member
|
Thank you again for this contribution. |
Member
|
This is in v1.8.9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a draft of the feature discussed in #125
I vibe coded the UI changes, so I definitely want to redo that part (cleaner code, similar flow to admin settings).
But I am happy with the basic flow: Editors also have a settings button.
In the settings, there is only the option to update ones own password for editors.
There you have to put in your current password and the new password twice, as it is very common.
What are your thoughts? Should we also allow Viewers to update their password?
The route, I added is handcrafted.
I followed your implementation of updating a user.