Skip to content

Conversation

@sgherbst
Copy link
Collaborator

This PR fixes two small issues in the way TCL files are generated for running Vivado simulations.

  • `define macros containing literal double-quotes are now supported. This already seems to be supported in the other simulators.
  • Paths with spaces are now supported (for the build directory, source files, library files, and include directories). The only other simulator that seems to support this is iverilog.

Though minor, these updates are useful for me because they allow me to pass path information into Verilog code via `define macros (e.g., the path to a file to be used for $readmemb).

Copy link
Owner

@leonardt leonardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgherbst sgherbst merged commit f8bd31e into master Mar 14, 2020
@leonardt leonardt deleted the paths_w_spaces_2 branch March 14, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants